It's hard to get reliable information on Warlocks atm, but the general consensus for Affliction is that Kyrian is your best choice, as it has strong synergy with their kit, especially after the buffs it has received. That said, the other abilities are all still viable options for Affliction.
bis Covenant for demonology warlock in Shadowlands
Ever since Demonbolt began working with Decimating Bolt, Necrolord has been a very strong option for Demonology, especially on Single Target. That said, the damage falls off a bit on AoE, so you're likely better off going with Night Fae for pure AoE damage or Venthyr for solid AoE damage and utility if Mythic+ is what you prefer.
bis Covenant for destruction warlock in Shadowlands
While Kyrian does appear to be the best pick for Destruction, it doesn't have as much of a lead over the others, atleast not when compared to Affliction. To be safe, I've kept all of the covenants ranked as good, but do keep in mind that Kyrian has a slight edge over the other three at the moment.